Luke Redpath
Luke Redpath
@dazy1030 so I think based on the above I may have found a fix for this, which is applying the same fix I made above directly to `Effect.cancellable` which is...
@stephencelis we've spoke a few times in Slack about the issues I've been seeing in our production app with this cancellation thread race issue - do you have any ideas...
This workaround doesn't work for me. I have an API client that requires a router (using `URLRouting`) and requires that router to be sendable. When I try to construct my...
@stephencelis unfortunately it isn't that straightforward - I can make my router type conform to `Sendable`, but as soon as I use one of the built-in modifiers in `URLRouting`, e.g....
@yqiang good suggestion - could you please submit a PR?
I'm happy to accept a PR.
This fix worked for me locally: https://github.com/pointfreeco/swift-composable-architecture/compare/main...lukeredpath:swift-composable-architecture:lukeredpath/will-set-crash FWIW, both of these solutions work in isolation - I've tested with both the notification queue fix and the change to `mainActorASAP`, I'm...
Yes I will see what I can do. I think only one fix is necessary but I'm not sure which is best.
@larryonoff thank you, I was unable to get a reproducing test - I was using `observe {}` which takes care of shunting on to the main thread for you so...
Fixed by #3247