FluentEmail icon indicating copy to clipboard operation
FluentEmail copied to clipboard

Version 3.0.2 should include SendWithTemplateAsync but it doesn't

Open Renevdo opened this issue 3 years ago • 3 comments

Looking into the source code, Version 3.0.2 should include the functionality to send SendGrid email with templates. But including the NuGet version 3.0.2 of FluentEmail.SendGrid, inspecting, this function is missing.

image

https://github.com/lukencode/FluentEmail/blob/master/src/Senders/FluentEmail.SendGrid/SendGridSender.cs

` public async Task<SendResponse> SendWithTemplateAsync(IFluentEmail email, string templateId, object templateData, CancellationToken? token = null) { var mailMessage = await BuildSendGridMessage(email);

        mailMessage.SetTemplateId(templateId);
        mailMessage.SetTemplateData(templateData);

        var sendResponse = await SendViaSendGrid(mailMessage, token);

        return sendResponse;
    }

`

Renevdo avatar Mar 24 '22 10:03 Renevdo

Very confusing indeed, and I was really relying on this when choosing my implementation. Did you find a workaround? Did it work on versions before 3.0.2?

jazzmanro avatar Apr 03 '22 08:04 jazzmanro

I removed the Sendgrid package, and implemented it using FluentEmail.Core, and my own build of the FluentEmail.Sendgrid with the function included.

Renevdo avatar Apr 04 '22 08:04 Renevdo

I confirm, there is a lot missing in respect to what is in the source code on GitHub

Marek00Malik avatar Mar 22 '23 12:03 Marek00Malik