lukejacksonn
Fix ReactDOMServerBrowser export
The ReactDOMServerBrowser export in src/index.js was exporting ./react-dom, not ./react-dom-server-browser
So it does, I believe this change was made here https://github.com/lukejacksonn/es-react/pull/13/files#diff-1fdf421c05c1140f6d71444ea2b27638R6
Hey @iAmNathanJ was there a reason behind this? I don't use react-dom-server-browser so was really just trusting that it worked properly as suggested.
If it is not then it is unfortunate because I've tried to pin the version of this library to that of latest react and they haven't released a new version since 16.13.1 so we either break the match or wait until the next release from react.
So it does, I believe this change was made here https://github.com/lukejacksonn/es-react/pull/13/files#diff-1fdf421c05c1140f6d71444ea2b27638R6
Hey @iAmNathanJ was there a reason behind this? I don't use
react-dom-server-browserso was really just trusting that it worked properly as suggested.If it is not then it is unfortunate because I've tried to pin the version of this library to that of latest react and they haven't released a new version since
16.13.1so we either break the match or wait until the next release from react.
@lukejacksonn yeesh, this is unfortunate. I apologize, that was a total miss on my part. You can see in my example repo that I was importing directly from the built file and must've overlooked the incorrect import in this barrel file.
I wonder if some kind of compatibility testing would help here. I'd be happy to help set something up, but not totally sure what that would look like to be honest.
The good news is that the server-browser variant of react-dom can still be accessed from this package, but only from its explicit path from 'es-react/react-dom-server-browser'. Unfortunately the named export from the index file is a lie. 😕
FWIW, I don't think you should break the match. If there's something I can do, please let me know.
No worries @iAmNathanJ these things happen! My bad too for not checking properly. Next version change we will update to what is here and then all will be good. It's not like react-dom-server-browser was supported in previous versions of es-react so it wasn't exactly a breaking change.
Apologies @Enva2712 hopefully you have forked this fork by now and got something working!
Yeah, I was just playing around with SSR in deno. I got it working using the explicit path before opening the PR