luckyframework
Replacing Turbolinks with @hotwired/turbo
Not sure why all of the CI is failing, but I've added this in to the website https://github.com/luckyframework/website/pull/932 We can test on a live site that it's fine before making the final merge.
Yes, the CI is failing and because the global specs using the support should_run_successfully method don't return the "downstream" error text, I'm blind. (Problem A)
We can test on a live site that it's fine before making the final merge.
Maybe it's enough, but I wanted to create specific lucky flowspecs to check we have the same behavior between before (@rails/ujs + turbolinks) and after (@hotwired/turbo only). (Problem B)
Right now, only the browser_authentification_app_skeleton uses lucky_flow, and for specific auth logic.
I have to tackle problem A before working on problem B, or I'll tiptoe in the dark, wondering why the specs failed.
Also for reference/note to myself :
https://github.com/hotwired/turbo-rails/blob/main/UPGRADING.md https://www.honeybadger.io/blog/hb-turbolinks-to-turbo/ https://discuss.hotwired.dev/t/migrating-from-ujs-to-turbo/1942
I'll put this PR as draft because, it's not ready as it is. I don't have bandwidth right now to work on this but anyone is welcome to continue this :-)
Oups ! Sorry for the accidental closing !
Looks like this just became a bit larger of a PR: A comparable version of this handler would need to be created: https://github.com/luckyframework/lucky/blob/main/src/lucky/redirectable_turbolinks_support.cr
Then whatever needs to be done to ensure this stuff works https://github.com/luckyframework/website/issues/947
Just dropping these links here so we have a spot to reference them.