Lucee4 icon indicating copy to clipboard operation
Lucee4 copied to clipboard

fix for LDEV-640

Open clitnak opened this issue 10 years ago • 6 comments

This looks like a big change but it is a lot of whitespace.

clitnak avatar Nov 20 '15 22:11 clitnak

Use this URL to hide whitespace in the diff https://github.com/lucee/Lucee4/pull/30/files?w=1

bdw429s avatar Nov 20 '15 22:11 bdw429s

we can not make that change, because this changes how scheduled tasks are working. let say you have a scheduled task that runs every minute and takes 90 seconds to execute, maybe you still expect that it runs every minutes even there are always 2 running at time. because you need the result of the scheduled task to be as fresh as possible. if we do a change like this we need a flag in the admin for this like "[x] skip if the previous thread is still running ..."

micstriit avatar Dec 07 '15 09:12 micstriit

In addition we should make a chage like this only for Lucee 5

micstriit avatar Dec 07 '15 09:12 micstriit

I would be in favor of adding an option to only allow a single instance of the task. I would say that is the most common expectation and I've had multiple issues where tasks run long and start to break things when more than one of them is running.

bdw429s avatar Dec 07 '15 18:12 bdw429s

this is a setting from travis: Limiting Concurrent Builds # The maximum number of concurrent builds depends on the total system load, but one situation in which you might want to set a particular limit is: if your build depends on an external resource and might run into a race condition with concurrent builds. You can set the maximum number of concurrent builds in the settings pane for each repository.

micstriit avatar Nov 14 '16 17:11 micstriit

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 22 '19 19:10 CLAassistant