Saikari comments

Results 87 comments of


                                            Saikari

update libxlsxwriter

Can you make `.patch` files instead of `io.replace`?

TODO: validate wasm build for package `minizip` is repaired by https://github.com/xmake-io/xmake/pull/6890 ``` local config_version_file = path.join(package:installdir("lib"), "cmake", "minizip", "minizipConfigVersion.cmake") if package:is_plat("cross") and package:check_sizeof("void*") == "4" and os.exists(config_version_file) then io.replace(config_version_file, [[if("${CMAKE_SIZEOF_VOID_P}"...

update libxlsxwriter

Minizip's cmakeconfig would request ZLIB's cmakeconfig via `find_dependency(zlib)` that is being avoided in #8300 ``` error: @programdir/core/sandbox/modules/os.lua:273: CMake Error at /github/home/.xmake/packages/c/cmake/4.0.3/b686e3b7911246e2bfa1b52ae27762fe/share/cmake-4.0/Modules/CMakeFindDependencyMacro.cmake:78 (find_package): Could not find a package configuration file provided...

update libxlsxwriter

/gemini review

无法编译ncnn

I think there is package called criterion that relies over protobuf as well, protoc and protobuf versions should be fixed to be specific value to make them compatible with each...