mfx_dispatch icon indicating copy to clipboard operation
mfx_dispatch copied to clipboard

CMake build broken in 1.34

Open rcombs opened this issue 4 years ago • 5 comments

25bde3f955259bcfd9f282abd402734c31dd5305 added src/mfx_driver_store_loader.cpp but didn't list it in the CMake project.

rcombs avatar Feb 03 '21 23:02 rcombs

Also needs -lole32 in the .pc on windows.

rcombs avatar Feb 04 '21 00:02 rcombs

And also -luuid, though that seems to be missing on the autotools build as well.

rcombs avatar Feb 04 '21 02:02 rcombs

if you make a pull request I'd land it immediately, thank you for reporting.

lu-zero avatar Feb 04 '21 05:02 lu-zero

The change in the .cmake is easy enough, but I'm not entirely sure how to handle the pkgconfig changes, since they're platform-specific.

rcombs avatar Feb 04 '21 05:02 rcombs

And also -luuid, though that seems to be missing on the autotools build as well. This is strange:

https://github.com/lu-zero/mfx_dispatch/blob/master/configure.ac#L18

        DLLIB="-lole32 -luuid"

You'd have to change the .pc.cmake template and add in cmake the same logic present in configure.ac

lu-zero avatar Feb 04 '21 08:02 lu-zero