bubblezone icon indicating copy to clipboard operation
bubblezone copied to clipboard

use private CSI sequence for marking

Open srlehn opened this issue 2 years ago โ€ข 0 comments

๐Ÿš€ Changes proposed by this PR

๐Ÿ”— Related bug reports/feature requests

ISSUE: The ANSI CSI sequence used for marking should be a private one #19

๐Ÿงฐ Type of change

  • [โœ” ] Bug fix (non-breaking change which fixes an issue).

Use private CSI sequence instead of the already defined CBT CSI sequence.

Fixes #19

๐Ÿ“ Notes to reviewer

https://en.wikipedia.org/wiki/ANSI_escape_code#CSI_(Control_Sequence_Introducer)_sequences

"A subset of arrangements was declared "private" so that terminal manufacturers could insert their own sequences without conflicting with the standard. Sequences containing the parameter bytes <=>? or the final bytes 0x70โ€“0x7E (pโ€“z{|}~) are private. "


https://www.ecma-international.org/wp-content/uploads/ECMA-48_5th_edition_june_1991.pdf

5.4.d) F is the Final Byte; it consists of a bit combination from 04/00 to 07/14; it terminates the control sequence and together with the Intermediate Bytes, if present, identifies the control function.

Bit combinations 07/00 to 07/14 are available as Final Bytes of control sequences for private (or experimental) use.

5.4 Table 3: ("Z" = column 05, row 10 -> "CBT")


https://vt100.net/docs/vt510-rm/chapter4.html (search for "CBT)

๐Ÿค Requirements

  • [โœ” ] โœ I have read and agree to this projects Code of Conduct.
  • [โœ” ] โœ I have read and agree to this projects Contribution Guidelines.
  • [โœ” ] โœ I have read and agree to the Developer Certificate of Origin.
  • [ โœ”] ๐Ÿ”Ž I have performed a self-review of my own changes.
  • [ โœ”] ๐ŸŽจ My changes follow the style guidelines of this project.
  • [ ] ๐Ÿ’ฌ My changes as properly commented, primarily for hard-to-understand areas.
  • [ ] ๐Ÿ“ I have made corresponding changes to the documentation.
  • [ ] ๐Ÿงช I have included tests (if necessary) for this change.

srlehn avatar Nov 14 '23 23:11 srlehn