idea-conventional-commit icon indicating copy to clipboard operation
idea-conventional-commit copied to clipboard

Version 0.25.0 requires external resources and cannot be used in an isolated network environment.

Open r1235613 opened this issue 8 months ago • 7 comments

After updating to version 0.25, the auto-complete feature stopped functioning. It was discovered that the program attempts to access some external URLs (e.g https://json-schema.org/draft-04/schema).

Please consider introducing a feature to disable access to external resources. Thank you very much!

r1235613 avatar Aug 19 '25 06:08 r1235613

Hey. Indeed, that URL, and a JSON schema coming from this repo.
I'll see if they can be moved to "local" resources.

But for example, how do you deal with JSON schemas for other things? They probably also require network activity.

lppedd avatar Aug 19 '25 07:08 lppedd

I think the basic features are already very useful, including suggestions drawn from the built-in dictionary and Git history. The online features are great, but in some environments they can be quite frustrating.

r1235613 avatar Aug 21 '25 13:08 r1235613

Adding to this that I've run into this issue myself, too. I think this should be considered a critical issue because beyond the autocomplete feature, if you don't have network connectivity and try to access the plugin settings, the IDE will freeze waiting for the remote resources to be loaded. I don't think it times out and unfreezes at some point, either (or at least I haven't seen it).

atan2l avatar Oct 03 '25 10:10 atan2l

I need to test it out. Basically the only requirement is turn off connectivity, correct?

lppedd avatar Oct 03 '25 10:10 lppedd

This is probably related to schema validation.
I'll try to have the schema locally only.

lppedd avatar Oct 03 '25 10:10 lppedd

I need to test it out. Basically the only requirement is turn off connectivity, correct?

I thought so, but I'm not so sure now. Trying to reproduce the issue to confirm it I'm seeing something different. I've disabled network connectivity but the IDE isn't freezing this time. It simply doesn't show the list of possible commit types.

Image

The ISP I use was having issues yesterday when I ran into this problem, so here's what I think happened. I apparently had connectivity, but very unreliable. So obtaining the JSON schema from a remote source wasn't failing, it was just taking forever causing the IDE to freeze for about 5 minutes before I killed the process.

This is probably related to schema validation. I'll try to have the schema locally only.

You're probably dead-on with this. Something I'm sure you can reproduce is turning off network connectivity, opening the commit window and seeing this error notification over and over. In this loop, when trying to close the IDE, it will warn you about currently running background processes.

Image

atan2l avatar Oct 04 '25 14:10 atan2l

Yeah I think we're on the right track. Thanks for the further investigation!

All in all, having a schema URL pointing to an HTTP resource isn't the best choice. It's a good choice to allow editing outside of the IDE, but it should be added ONLY when exporting the custom tokens file.

By default the used schema should be the bundled one.

lppedd avatar Oct 04 '25 14:10 lppedd