progrockdiffusion icon indicating copy to clipboard operation
progrockdiffusion copied to clipboard
verified publisher icon lowfuel

create a settings class

Open huo-ju opened this issue 3 years ago • 2 comments

There are too many global variables in the prd.py, so I move all the user input settings into a new Settings class. It will make it easy for future development, share settings and unit tests.

huo-ju avatar Aug 07 '22 17:08 huo-ju

Thanks for doing this! I am reviewing it, but wanted to make you aware that another contributor is working on something very similar already, so I need to check with them first and see how best to proceed.

lowfuel avatar Aug 08 '22 16:08 lowfuel

That’s no problem, and I will be happy to see if another contributor can finish this. Thanks!

huo-ju avatar Aug 08 '22 17:08 huo-ju

Hi, sorry this took so long. I've just merged my settings overhaul (based on some of your changes with quite a few other adjustments / fixes / etc. of mine. I'm closing this pull request as a result.

lowfuel avatar Sep 09 '22 15:09 lowfuel