opentitan icon indicating copy to clipboard operation
opentitan copied to clipboard

[spi_device] Add an event for unexpected host behavior

Open eunchan opened this issue 4 years ago • 8 comments

Host jumps the read address

The SPI_DEVICE assumes the host reads the address relatively sequentially. If not, (read next 1kB then roll back to previous 1kB), it is worth to notify SW to handle the scenario.

eunchan avatar Jan 13 '22 01:01 eunchan

(Removing the hotlist label on the basis that this is a P2. Feel free to re-add if you would like this to be discussed in the next SW WG.)

mundaym avatar Mar 28 '22 15:03 mundaym

is this one still valid given the recent mailbox change?

tjaychen avatar May 11 '22 17:05 tjaychen

is this one still valid given the recent mailbox change?

Yes. Still need to detect the host's incorrect behaviors.

eunchan avatar May 11 '22 17:05 eunchan

Triaged for spi_device. Assigning to M2.5 with https://github.com/lowRISC/opentitan/labels/Priority%3AP2 because we should check with the product team if we need to handle such unexpected host behavior. If not, we can defer this to https://github.com/lowRISC/opentitan/labels/Type%3AFutureRelease.

andreaskurth avatar Feb 24 '23 13:02 andreaskurth

estimate 8 remaining 2023-03-19 8

hcallahan-lowrisc avatar Mar 22 '23 16:03 hcallahan-lowrisc

Adding the FutureRelease label as we consider this an useful feature to have in a production instantiation of OpenTitan.

moidx avatar Apr 05 '23 14:04 moidx

@moidx Do we even have a usecase that would not do continuous reads? Because if not I would advocate no change at this point.

msfschaffner avatar Feb 22 '24 18:02 msfschaffner

I am ok if we close this issue as not planned. Given the schedule constraints of this iteration, it is perfectly fine to document this limitation in the specification. The use case is restricted to linear access.

moidx avatar Feb 22 '24 18:02 moidx