SQLpage icon indicating copy to clipboard operation
SQLpage copied to clipboard

feat: add lazy component

Open mtt-artis opened this issue 1 year ago • 4 comments

Hi šŸ‘‹,

I'm working with some resource-intensive queries that take some time to execute, and the embed option on the card component works really well. However, I’d like to prevent layout shifts and avoid having cards nested inside other cards.

The lazy component follows a similar logic but provides an element you can style before it's replaced with the actual content.

Please feel free to make any changes, rename the component (coming from React/Solid, that's what comes naturally to me), or guide me in the right direction.

If you like this implementation, I'd be happy to add it to the documentation.

mtt-artis avatar Sep 22 '24 15:09 mtt-artis

Hello ! This sounds like a very useful component to add, and I'll be happy to integrate it. Thank you ! :blush:

Could you please:

lovasoa avatar Sep 22 '24 15:09 lovasoa

hi šŸ‘‹, Thanks for your comments

  • remove the indentation changes to make the code easier to review

could we invest for future change and make the indentation consistent across the file ?

I can add tests and documentation during the next WE if you don't mind šŸ˜‰

mtt-artis avatar Sep 22 '24 19:09 mtt-artis

Yes, we can set an indentation standard, but maybe after your PR? You are going to end up with large conflicts for nothing, otherwise. I need a clean diff in this PR to review it.

lovasoa avatar Sep 22 '24 19:09 lovasoa

Hello ! Any news on this ? I think only docs and tests are missing, then we can merge !

lovasoa avatar Oct 19 '24 21:10 lovasoa