workless icon indicating copy to clipboard operation
workless copied to clipboard

Fix rails deprecation warnings (use after_commit -> { })

Open sergeykish opened this issue 9 years ago • 4 comments

Hello

That's part of the rails 5 deprecation warnings cleanup. It fixes DEPRECATION WARNING: Passing string to define callback. Change is almost mechanical and I hope new lambda syntax is quite old already (ruby 1.9).

I've also noticed specs failure with rspec 3, changed gemspec to use rspec 2 instead.

sergeykish avatar Dec 29 '16 15:12 sergeykish

@lostboy any problem with this pull request?

sergeykish avatar May 03 '17 15:05 sergeykish

@sergeykish This repo seems really inactive. Any thoughts on mantaining your own version with Rails 5 deprecation cleanup, and 5.1 support?

unmultimedio avatar May 03 '17 21:05 unmultimedio

Hey guys, I've left this for so long, apologies for going awol. If people are still keen I can put some time to bringing the repo and gem up to speed.

lostboy avatar Aug 30 '17 15:08 lostboy

@lostboy glad you're back. I've checked this in depth couple of months ago, and I've found one fork that has been mantained and updated to work with Rails 5: https://github.com/davidakachaos/workless_revived & It's working ok!

I think you should talk to @davidakachaos to join efforts! Thanks for coming back.

unmultimedio avatar Aug 30 '17 16:08 unmultimedio