temporal-time-utils icon indicating copy to clipboard operation
temporal-time-utils copied to clipboard

add Entitty utility

Open swyxio opened this issue 4 years ago • 2 comments

there are some type considerations i havent figured out yet but this is the kind of developer experience i am looking for.

swyxio avatar Jan 13 '22 00:01 swyxio

Some other general comments.

This type of workflow is good for when you want to ensure only a single update is applied concurrently. The implementation is a bit limited at the moment because if the update function takes longer to process than the rate of incoming update requests the workflow history will reach the limit. The nice side effect of this workflow structure is that we can carry the pending work on after we continue as new, we should consider adding that.

Lastly, you could really use some tests for this code. It doesn't work at the moment and if we add more complex features without tests it probably will be buggy.

bergundy avatar Jan 13 '22 06:01 bergundy

The implementation is a bit limited at the moment because if the update function takes longer to process than the rate of incoming update requests the workflow history will reach the limit.

i am planning to switch to startChild once the type bug is fixed, which wouldnt solve it but would make it non blocking at least

The nice side effect of this workflow structure is that we can carry the pending work on after we continue as new, we should consider adding that.

not sure how to achieve that, i thought we have to drain before continuing?

swyxio avatar Jan 13 '22 17:01 swyxio