lore icon indicating copy to clipboard operation
lore copied to clipboard

[lore-hook-connect] props from connect should override props from parent component

Open jchansen opened this issue 9 years ago • 1 comments

If you pass a prop called countries to a component wrapped with connect, that also defines that prop (for whatever reason), it does not override the parent prop.

This is not expected behavior. Props provided through connect should override props from parent components.

jchansen avatar Feb 01 '17 23:02 jchansen

For reference, this is the line in the code that shows parent props overwriting connect-generated props:

https://github.com/lore/lore/blob/master/packages/lore-hook-connect/src/connect.js#L125

jchansen avatar Jun 24 '18 02:06 jchansen