loopback.io icon indicating copy to clipboard operation
loopback.io copied to clipboard

Typo in Documentation

Open Ojvar opened this issue 4 years ago • 2 comments

Hello, In the page: https://loopback.io/doc/en/lb4/express-with-lb4-rest-tutorial.html,

According to example, this snippet in document:

 // For testing purposes
  public async stop() {
    if (!this.server) return;
    await this.lbApp.stop();
    this.server.close();
    await pEvent(this.server, 'close');
    this.server = undefined;
  }

must be :

  // For testing purposes
  public async stop() {
    if (!this.server) return;
    await this.lbApp.stop();
    this.server.close();
    await once(this.server, 'close');
    this.server = undefined;
  }

Thanks

Ojvar avatar Oct 10 '21 07:10 Ojvar

hey is this issue still open?? can I work on it??

VaishnaviMudaliar avatar Mar 21 '22 06:03 VaishnaviMudaliar

@VaishnaviMudaliar, sorry about the late reply. Definitely! The source is coming from the loopback-next repo: https://github.com/loopbackio/loopback-next/blob/master/docs/site/express-with-lb4-rest-tutorial.md.

dhmlau avatar Apr 20 '22 14:04 dhmlau