loopback-next icon indicating copy to clipboard operation
loopback-next copied to clipboard

feat: add prisma integration

Open achrinza opened this issue 4 years ago • 7 comments

closes #4195

Signed-off-by: Rifa Achrinza [email protected]

Checklist

  • [x] DCO (Developer Certificate of Origin) signed in all commits
  • [ ] npm test passes on your machine
  • [ ] New tests added or existing tests modified to cover all changes
  • [ ] Code conforms with the style guide
  • [x] API Documentation in code was updated
  • [ ] Documentation in /docs/site was updated
  • [ ] Affected artifact templates in packages/cli were updated
  • [ ] Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

achrinza avatar May 20 '21 17:05 achrinza

Any idea when this will be merged

VinayaSathyanarayana avatar Jun 14 '21 01:06 VinayaSathyanarayana

Things have been a bit hectic at my end, so unfortunately this was put on pause; Will try to timebox ~for the upcoming week.~ soon.

achrinza avatar Jun 17 '21 13:06 achrinza

Hey @achrinza I was looking at this PR and I get a question, how good would it be to "transform" Loopback Filter into a Prisma filter? Prisma has features that are not supported by Loopback Filter, so those features would be lost (eg: _avg), what do you think is the best approach to continue this integration?

dmunozb avatar Aug 03 '21 23:08 dmunozb

Hi @dmunozb, apologies for not replying earlier; I don't have a concrete solution for Prisma filters that don't have an LB4 equivalent at the moment.

I'll continue to work on the Prisma extension where I have time, though I can't provide any guarantees at the moment.

Most of the extension already works with decent code coverage, just some bugs on the intermediate binding-related features that need to be squashed with some additional features that I'm looking to add.

achrinza avatar Aug 26 '21 16:08 achrinza

Pull Request Test Coverage Report for Build 1197656949

  • 160 of 204 (78.43%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 75.987%

Changes Missing Coverage Covered Lines Changed/Added Lines %
extensions/prisma/src/component.ts 83 100 83.0%
extensions/prisma/src/helpers/lb4-to-prisma-filter.ts 41 68 60.29%
<!-- Total: 160 204
Totals Coverage Status
Change from base Build 1192751698: -0.02%
Covered Lines: 17048
Relevant Lines: 18083

💛 - Coveralls

coveralls avatar Sep 02 '21 22:09 coveralls

Any progress on this please?

VinayaSathyanarayana avatar Oct 13 '21 01:10 VinayaSathyanarayana