loopback-datasource-juggler icon indicating copy to clipboard operation
loopback-datasource-juggler copied to clipboard

fix: `null` value not persisted for JSON, Any, Object types (v4)

Open achrinza opened this issue 4 years ago • 4 comments

I don't have enough familiarity with the codebase to write the necessary tests; We can put it into the backlog or someone else can help write and push some tests onto this branch :)

fixes #1895

Signed-off-by: Rifa Achrinza [email protected]

Checklist

  • [x] Sign off your commits with DCO (Developer Certificate of Origin)
  • [x] npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • [x] Code conforms with the style guide
  • [x] Commit messages are following our guidelines

achrinza avatar Aug 28 '21 13:08 achrinza

Pull Request Test Coverage Report for Build 1226264821

  • -4 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 84.733%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/dao.js 0 4 0.0%
<!-- Total: 0 4
Totals Coverage Status
Change from base Build 1223745102: -0.02%
Covered Lines: 7159
Relevant Lines: 8150

💛 - Coveralls

coveralls avatar Sep 12 '21 09:09 coveralls

Pull Request Test Coverage Report for Build 1226264821

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 84.741%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/dao.js 0 4 0.0%
<!-- Total: 0 4
Totals Coverage Status
Change from base Build 1223745102: -0.01%
Covered Lines: 7159
Relevant Lines: 8150

💛 - Coveralls

coveralls avatar Sep 12 '21 09:09 coveralls

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 11 '21 10:11 stale[bot]

We have the same issue. This solves it. What is needed for this to be merged?

siimsams avatar Jun 19 '23 15:06 siimsams