sdk-codegen icon indicating copy to clipboard operation
sdk-codegen copied to clipboard
verified publisher icon looker-open-source

feat: Create NetStandard 2.0 library

Open drstrangelooker opened this issue 1 year ago • 5 comments

feat: Create NetStandard 2.0 library #1398

drstrangelooker avatar Sep 26 '24 22:09 drstrangelooker

@jkaster or @josephaxisa can either of you comment on this change?

drstrangelooker avatar Oct 28 '24 16:10 drstrangelooker

@ksjoberg Can you pull down this branch and see if you can get the tests to work? I don't currently have a windows machine available to me and my linux box with Rider is failing to run the tests. Thanks.

jkaster avatar Nov 09 '24 02:11 jkaster

Codegen Tests

441 tests  +2   425 ✅ +2   37s ⏱️ -1s  19 suites ±0    16 💤 ±0    1 files   ±0     0 ❌ ±0 

Results for commit e0d9213f. ± Comparison against base commit 14363682.

github-actions[bot] avatar Nov 09 '24 02:11 github-actions[bot]

I checked and there are 7 tests failing and 17 tests passing. You can run the tests from the command prompt using dotnet test in the LookerSdk.Tests directory. My VS2022 correctly identifies the tests and allows me to debug them interactively. I think the 441 tests run by github-actions might not include the tests in the C# LookerSdk.Tests project.

ksjoberg avatar Nov 11 '24 08:11 ksjoberg

Thanks, @ksjoberg! I ran out of time to work on this more last week, but I'll be able to resume work on it again this week, and JetBrains has also suggested a work-around to get the tests running locally for me. If that works, progress will be much more rapid.

jkaster avatar Nov 11 '24 22:11 jkaster