logseq
Rendering of inline symbols broken in v0.8.9
What happened?
In previous versions of logseq, some symbols could be used inline without enclosing them in $$. The latest update to v0.8.9 broke this and previously added symbols like \times are no longer rendered correctly.
Reproduce the Bug
- Add a native-parser supported inline symbol (
\times,\rArr) without enclosing in$$in any block - Inline symbol is not rendered
Expected Behavior
Inline symbol to be rendered without enclosing in $
Screenshots
Desktop Platform Information
Mac OS v12.6, Logseq v0.8.9
Mobile Platform Information
No response
Additional Context
No response
Still broken. I don't think any of the in-line '' commands are rendering as "\alpha", "\beta", "\gamma", etc are all just rendering as blank space.
Very annoying as it makes much of my previous notes completely unreadable without looking at the markdown directly.
This is on Windows 10, Logseq v0.8.10
The regression is still present in v0.8.12.
It seems almost no-one is using this feature?
I've resorted to enclosing these symbols inside the inline Latex demarcator like '$\alpha$'. These work everywhere in the database.
This has been driving me crazy too! I've just been too busy to do anything about it / even complain!
I have some time now and I'm running a git bisect to nail down exactly which commit the problem comes from — I'll report back with results soon!
Seems to be the breaking commit:
I'll take a look and try to draft a patch!
Nice work!
From: Brooks Rady @.> Sent: Sunday, January 15, 2023 1:31:31 AM To: logseq/logseq @.> Cc: Noah Piper @.>; Comment @.> Subject: Re: [logseq/logseq] Rendering of inline symbols broken in v0.8.9 (Issue #7054)
Seems to be the breaking commit: [image]https://user-images.githubusercontent.com/6251883/212479822-61115bd0-42d7-482b-a254-4e00cd80462e.png I'll take a look and try to draft a patch!
— Reply to this email directly, view it on GitHubhttps://github.com/logseq/logseq/issues/7054#issuecomment-1382823318, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXQCKKIUFIXFPSKPCFLDF2LWSLBFHANCNFSM6AAAAAARJ3LBVY. You are receiving this because you commented.Message ID: @.***>
Specifically, it's this line for me:
I'm trying to find a way to keep the security check without murdering all \ escapes
Easy win:
The sanitizing was taking place on a Clojure map and not actually HTML data — the :html call just needs to come first (to return the HTML from that map) and then it can be sanitized as before!
I'll test these changes on the latest version of the code then submit a PR!