logparser icon indicating copy to clipboard operation
logparser copied to clipboard

Smith-Waterman algorithm implementation under Apache 2

Open lopozz opened this issue 11 months ago • 0 comments

PR for https://github.com/logpai/logparser/issues/125

Improvements from the previous version of the alignment.py:

  • improved readability of the code
  • removed global variables (match_award, mismatch_penalty, gap_penalty)
  • introduced reference to algorithm
  • apache 2.0 licence

In writing this implementation I decided to respect the signature of the original script to have a drop-in replacement for the algorithm. No additional dependencias were introduced.

The demo.py script was run successfully

Optionally I also wrote unit tests on the old script to compare it with my implementation. I could also commit those to maintain consistency in case of future PRs

lopozz avatar Mar 06 '25 09:03 lopozz