logisim-evolution icon indicating copy to clipboard operation
logisim-evolution copied to clipboard

Negated enable for multiplexer

Open cosineblast opened this issue 2 years ago • 2 comments

This is an in-progress PR, consisting of an implementation for negated enables for the multiplexer, and eventually for the demultiplexer as well.

As of now, the feature modifies the enable attribute for the multiplexer to add an invert option, which inverts the input for the enable in the component, as well as adding the little indication circle. This new invert option for the enable attribute takes the value id of 'inverted' in the XML.

shot

So, are the designs for the invert enable OK? If that's the case, I will then work on the demultiplexer as well.

cosineblast avatar Sep 04 '23 14:09 cosineblast

Sorry for the late feedback. The designs are OK. Regarding the addition of localization strings, please make sure that you add placeholders to all languages for which localization is offered.

@BFH-ktt1: Any thoughts from your side?

maehne avatar Aug 16 '24 12:08 maehne

Please see this comment by @davidhutchens in the related PR #1855 regarding labeling the activity level of the enable input.

maehne avatar Aug 16 '24 12:08 maehne