angular-material-datetimepicker icon indicating copy to clipboard operation
angular-material-datetimepicker copied to clipboard
verified publisher icon logbon72

disableParentScroll will impact the display of the dialog

Open huangjun604 opened this issue 9 years ago • 4 comments

Using disableParentScroll: false will make the display of dialog incorrect at latest version of Angular Material

Demo: http://codepen.io/anon/pen/VKQWGO

If you change the version to old one, such as 0.7.1, it is correct

huangjun604 avatar Oct 07 '16 07:10 huangjun604

It's a behavior of Angular Material dialog service. 0.7.1 vs 1.1.0 vs 1.1.1 @huangjun604 I don't see how it's related to this datetimepicker?

hexadecy avatar Feb 07 '17 21:02 hexadecy

Hi @hexadecy , thanks for your response.

https://github.com/logbon72/angular-material-datetimepicker/blob/master/js/angular-material-datetimepicker.js#L182

the datetimepicker plugin uses the disableParentScroll: false on above link, and we cannot modify it. So it would cause the display error by using this plugin with higher angularjs

huangjun604 avatar Feb 08 '17 06:02 huangjun604

Ok maybe you can make a PR for that, by adding a directrive attribute like parent-scroll=Boolean.

hexadecy avatar Feb 08 '17 12:02 hexadecy

@huangjun604 can you try it?

hexadecy avatar Feb 22 '17 04:02 hexadecy