devpod icon indicating copy to clipboard operation
devpod copied to clipboard

devpod up --recreate flag does not work as documented

Open vegasje opened this issue 2 years ago • 0 comments

What happened? The --recreate flag does not appear to work as documented here: https://devpod.sh/docs/developing-in-workspaces/devcontainer-json#devcontainerjson-development-flow

I made an error when composing my devcontainer.json file, and DevPod returned an error message: fatal agent error: devcontainer up: parsing devcontainer.json: json: invalid number literal, trying to unmarshal "\"8081:80\"" into Number.

I fixed the error and then attempted to recreate the container. DevPod returned the same error message despite the error being resolved: fatal agent error: devcontainer up: parsing devcontainer.json: json: invalid number literal, trying to unmarshal "\"8081:80\"" into Number.

What did you expect to happen instead? I expected the container to be recreated from scratch and the modifications in devcontainer.json to be used when creating the new container.

How can we reproduce the bug? (as minimally and precisely as possible)

  • Bring a container up using devpod up.
  • Modify the devcontainer.json contents.
  • Issue devpod up ./ --recreate.

My original devcontainer.json (with syntax error):

{
	"name": "devpod-test",
	"build": {
		"dockerfile": "Dockerfile"
	},
	"forwardPorts": ["8081:80"]
}

My updated devcontainer.json (without syntax error):

{
	"name": "devpod-test",
	"build": {
		"dockerfile": "Dockerfile"
	},
	"forwardPorts": [80]
}

Local Environment:

  • DevPod Version: v0.1.5
  • Operating System: mac
  • ARCH of the OS: ARM64

DevPod Provider:

  • Cloud Provider: aws

Anything else we need to know? I have also noticed that changes made to the Dockerfile are not picked up when using the --recreate flag.

vegasje avatar May 19 '23 15:05 vegasje