Remove "noscale" argument

Open Haoxiang-Wang opened this issue 3 years ago • 1 comments

https://github.com/locuslab/FLYP/blob/61275a47af1cc10aa1398cfce2301e265af6f4c4/src/datasets/common.py#L142

It seems the noscale argument is useless in this codebase, and the non-existence of args.noscale incurs errors. So it's better to remove all occurrences of noscale and args.noscale in src/datasets/common.py.

Feb 06 '23 07:02 Haoxiang-Wang

Hi @Haoxiang-Wang , Thanks a lot for pointing this out. noscale argument was for some experiments I was doing initially to compare normalizing features with not normalizing them. I will update the codebase and remove this argument.

Feb 06 '23 10:02 SachinG007