udig-platform icon indicating copy to clipboard operation
udig-platform copied to clipboard

Add 'Automatic-Module-Name' to all MANIFEST.MF

Open sschulz92 opened this issue 4 years ago • 4 comments

This new attribute is required to move on to Java 9 or newer.

sschulz92 avatar Sep 24 '21 13:09 sschulz92

Not sure about this one at the moment since compile-level and source-level is still Java 1.8.

And I remember some clitches Michael mentioned I'd like to clarify first ;)

fgdrf avatar Sep 24 '21 14:09 fgdrf

I would like to raise awareness this PR again as @egouge also want to change the MANIFEST.MF in the same way I want to do it. See the PR of Emily: https://github.com/locationtech/udig-platform/pull/575

Maybe we want to split the PR into dedicated changes, what do you think @egouge @fgdrf ?

sschulz92 avatar Oct 28 '21 09:10 sschulz92

I have no strong feeling abot one way or the other. I guess conflicts to the other PR are easy to resolve once joda-time fixes are on master.

Lets keep it as it is unless the other one is done. BTW: Is there a setting in eclipse to allow Automatic-Module-Name? Maybe its worth to document it in the Dev-guilde Eclipse IDE...

fgdrf avatar Oct 28 '21 10:10 fgdrf

I didn't actively make these changes when making changes for the joda time update so I'm thinking the version of Eclipse I used made this change automatically (or maybe I did quick fix and didn't realize it).

Apparently they do have a quick fix: https://bugs.eclipse.org/bugs/show_bug.cgi?id=525660

egouge avatar Oct 28 '21 20:10 egouge