udig-platform icon indicating copy to clipboard operation
udig-platform copied to clipboard

Fixed Problems with this method if setGraphics was never called

Open MSementsov-Ibk opened this issue 7 years ago • 2 comments

...and there was no run

Signed-off-by: Michael Sementsov [email protected]

MSementsov-Ibk avatar Oct 17 '18 05:10 MSementsov-Ibk

Ate the moment I do not understand how the description of this changeset is related to modified lines. Change indicates that is a safer implemantation which checks for null first before removing listeners.

Is it possible the not all changes were added to the commit?

fgdrf avatar Oct 23 '18 05:10 fgdrf

Sorry for the wonky description, what I meant is:

If setGraphics (AbstractDrawCommand.setGraphics(), in the superclass to MessageBubble) was never called, then a display was never registered and therefore there are also no Listeneres for setValid to remove.

It's a change from a while ago, so I can't say where I encountered this calling order, I'll post it here when I find it again.

MSementsov-Ibk avatar Oct 23 '18 07:10 MSementsov-Ibk