jts icon indicating copy to clipboard operation
jts copied to clipboard

isInCircleAdapt sketch Java port

Open Komzpa opened this issue 7 years ago • 4 comments

Do the non-robust calculation and calculation of error margin. If calculation is possibly not robust, fall back on slower math.

https://www.cs.cmu.edu/afs/cs/project/quake/public/code/predicates.c

References #298

Komzpa avatar Sep 04 '18 19:09 Komzpa

Need unit tests before rolling this in.

dr-jts avatar Sep 04 '18 19:09 dr-jts

Good find. This should provide both performance and robustness.

The same approach is currently used in computing the orientationIndex. Also based on Shewchuk's fine work.

dr-jts avatar Sep 04 '18 20:09 dr-jts

Just in case, I would be happy if someone familiar with java takes over this PR, to make proper formatting, unit tests and code style.

Komzpa avatar Sep 04 '18 22:09 Komzpa

Makes sense. And add some unit tests. Not sure when I'll have time to work on this though.

dr-jts avatar Sep 04 '18 22:09 dr-jts