geomesa icon indicating copy to clipboard operation
geomesa copied to clipboard

GEOMESA-3218 Add scala 2.12 compatibly changes required for 2.13

Open jfehr67 opened this issue 3 years ago • 4 comments

These are changes that shouldn't effect building in scala 2.12 but are required for 2.13.

jfehr67 avatar Jul 22 '22 23:07 jfehr67

thank you for doing all this!

elahrvivaz avatar Jul 29 '22 13:07 elahrvivaz

if you have any more pushes, could you do regular pushes and not force-pushes so that it's easier to compare the change? i will squash them down to a single commit on merge. thanks!

elahrvivaz avatar Jul 29 '22 17:07 elahrvivaz

looks like there are still some compile failures, are you planning on fixing them? i can also help out if you'd like.

elahrvivaz avatar Jul 29 '22 17:07 elahrvivaz

Sorry, there was two errors showing up as a result of accidentally including a 2.13 only import that should have been a 2.12 one. The change I made was changing that to the 2.12 import. I'll push separately going forward.

jfehr67 avatar Jul 29 '22 17:07 jfehr67

thanks again for getting 2.13 support started!

elahrvivaz avatar Aug 22 '22 14:08 elahrvivaz