localgovdrupal
Adds simple_media_bulk_upload
Stimulating a wider discussion on how to manage libraries like this.
- composer merge plugin
- composer asset packagist (https://asset-packagist.org/)
- specific repositories like above.
@andybroomfield thinks that most are moving to composer merge.
@Adnan-cds mentioned :
While considering the Dropzonejs module, please consider this: https://www.drupal.org/project/dropzonejs/issues/3316184
@andybroomfield is up for taking this forward:
- this might need to all be in the localgov_project
Drafting the composer merge plugin method here https://github.com/localgovdrupal/localgov_project/pull/173
@finnlewis @markconroy let's try to push this up tomorrow - it's reliant a beta library that's 4 years old and I feel like this is good enough to try
Discussing in Merge Tuesday:
@stephen-cox leaning towards composer-merge plugin rather than the npm asset packagist
@Adnan-cds is suggesting the approach here, but changing it a little to avoid specifying the dist and version, rather targeting the git repo and allow us to require a more open constraint.
Note: we really want to align on a preferred solution for LocalGov Drupal in general.
@stephen-cox points out that if we do require the libraries in the project composer.json, end users can decide whether to override this approach or not. So for us, we define our libraries in the localgov_project composer.json and remove the specific library definition here.
So it looks like @andybroomfield added the libraries to the localgov_project composer.json.
https://github.com/localgovdrupal/localgov_project/commit/1e749dd73bcf887d765c3b1bfe47b0ce86447db8
So can we just remove the specification of the repo from here? :
https://github.com/localgovdrupal/localgov/pull/729/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R7-R19
Noting that I get the same issue as https://github.com/localgovdrupal/localgov_assets/issues/2 when installing this PR (enyo/dropzone will install under vendor/enyo/dropzone)