horse icon indicating copy to clipboard operation
horse copied to clipboard

NIP-07 client does not work correctly with inproper permission request

Open jg1uaa opened this issue 2 years ago • 5 comments

Hi, I am testing horse with my nostr-signing-device-emulator (https://github.com/jg1uaa/nsdemu). I tried horse with iris (https://iris.to/), Snort(https://snort.social/) and nostter(https://nostter.vercel.app), and I found permission window of horse looks something strange compared wiith nos2x (https://github.com/fiatjaf/nos2x).

For example: (iris.to) login with NIP-07 → COM port selection → (no permission required) → login with timeline display (snort) login with NIP-07 → COM port selection → "read your public key" and "read your list of preferred relays" requested → window does not dismiss all buttons in permission window, only close with [x] (nostter) login with NIP-07 → COM port selection → (no permission required) → login with no timeline display

Normally, good-working-example by nos2x: (iris.to) login with NIP-07 → "read your public key" requested → login with timeline display (snort) login with NIP-07 → "read your public key" requested → "read your public key" and "read your list of preferred relays" requested → login with timeline display (nostter) login with NIP-07 → "read your public key" requested → "read your public key" and "read your list of preferred relays" requested → login with timeline display

Request/Response(from user) of permissions are not set correctly, client does not work properly. What can I help to solve this problem?

jg1uaa avatar Apr 02 '23 11:04 jg1uaa

I assume the same issue reproduces when using both the physical hardware and simulator. Can you please confirm?

It looks to be a react issue in the pop-up view of horse.

Nos2x:

image

Horse:

image

motorina0 avatar Apr 03 '23 07:04 motorina0

@jg1uaa the simulator looks pretty cool. Can it be used on MacOS also?

motorina0 avatar Apr 03 '23 07:04 motorina0

@motorina0 I don't have Apple machine so I cannot test nsdemu on MacOS. I succeeded to build nsdemu on other *BSD brothers such as FreeBSD/NetBSD so I think "maybe work" or "need small fix".

jg1uaa avatar Apr 03 '23 22:04 jg1uaa

@jg1uaa

I assume the same issue reproduces when using both the physical hardware and simulator. Can you please confirm?

motorina0 avatar Apr 04 '23 13:04 motorina0

@motorina0 is this problem? (with nsdemu on OpenBSD)

image

jg1uaa avatar Apr 09 '23 06:04 jg1uaa