Lorenz Meyer comments

Results 37 comments of


                                            Lorenz Meyer

PHP Deprecated

@hibatallahAouadni Thank you.

Add date_add, date_upd, soft delete and notification send time

> The soft delete is very interesting 👍, let's understand how to manage on legal side tho I missed to delete all customer data. But once this is fixed, there...

Add date_add, date_upd, soft delete and notification send time

@LouisAUTHIE I hope the rebase was successful. @souvrard Thanks for pointing this out.

Use on delete cascade on foreign keys

@leemyongpakva What do you mean by `manual delete`? In the BO, there is only an option to delete a comment, I didn't find an option to manually delete grades, usefulnesses...

Use on delete cascade on foreign keys

@leemyongpakva I see. Are you sure the code in https://github.com/PrestaShop/productcomments/blob/dev/src/Repository/ProductCommentRepository.php#L117-L119 works? There the related entities are deleted after `$this->remove($entity, true);`. Remove the comment will fail if there are related entities...

Use on delete cascade on foreign keys

@leemyongpakva Are you sure, the FK are present in your DB ? What is the output of `php bin/console doctrine:schema:update --dump-sql` on your site ? Can you show it?

Geolocation IP white list should be preconfigured

Sorry, I am the author of this questionnable pull request. Probably, it would have been a better choice to update the list while citing sources for the Bot-IPs. >It's been...