vimto icon indicating copy to clipboard operation
vimto copied to clipboard

fix: Switch to qemu Package from hugelgupf/vmtest

Open MarcWort opened this issue 1 year ago • 2 comments

Let me know what you think, or if you would do it differently. Another option would be to collect the arguments in []qemu.FN and use qemu.Start(fn).

Fixes #17

MarcWort avatar Jul 09 '24 15:07 MarcWort

Thanks for your PR! I had a quick look, seems like mostly argument handling has changed. What would you say is the benefit of changing to the new package?

lmb avatar Jul 14 '24 09:07 lmb

I guess the biggest benefit would be not being dependent on an old library without any updates (u-root < v0.12.0)

MarcWort avatar Sep 19 '24 08:09 MarcWort

Sorry for not giving you an answer for so long. From my point of view being stuck on an old version isn't a problem. If the code needs fixing we can just copy / rewrite it and remove the dependency altogether.

lmb avatar Jan 10 '25 11:01 lmb