slider icon indicating copy to clipboard operation
slider copied to clipboard

Lengths longer than the defined curve are not accounted for

Open daymxn opened this issue 2 years ago • 2 comments

When a Slider has a length property that is longer than the actual curve length, the Slider will extend its curve according to the following rules:

For bézier, catmull, and linear curves, it continues in a straight line from the end of the curve. For perfect circle curves, it continues the circular arc.

-From the Wiki

This is not currently accounted for. Although, lengths smaller than the defined curve seem to be. It's also worth noting that this is much more common than you'd think; especially when folks don't snap their sliders to the grid.

daymxn avatar Jul 06 '23 21:07 daymxn

Note that it appears the wiki is incorrect as far as perfect circle curves; they seem to extend in a straight line (the same as the others).

Although, the noted behavior may be valid for older beatmaps? Worth investigating further.

daymxn avatar Jul 06 '23 21:07 daymxn

Honestly speaking I'm not sure I'll have the bandwidth to look into this in the near future. PRs are always welcome though!

Liam-DeVoe avatar Jul 11 '23 00:07 Liam-DeVoe