benchmarks icon indicating copy to clipboard operation
benchmarks copied to clipboard

Outdated NodeJS version and no clustering

Open corporatepiyush opened this issue 8 years ago • 3 comments

Benchmark Uses NodeJS version 5.x .. the latest is 8.x

Also JRuby makes use of all CPU core due to JVM, you should compare it with ExpressJS with cluster module, that makes benchmark largely unfair.

corporatepiyush avatar Sep 29 '17 04:09 corporatepiyush

Benchmark Uses NodeJS version 5.x .. the latest is 8.x

Just because the hipsters like bumping versions to impress other people doesn't imply they actually ship something that is new or better. On the contrary: there is also a small performance improvement with every D release even though only a handful of people are working on it in their free time.

, you should compare it with ExpressJS with cluster module, that makes benchmark largely unfair.

Huh? The benchmark compares single-threaded programs for its analyzed languages. Also there is no difference between the cluster module and starting multiple threads. On the contrary due to Node's crappy load balancer, I know of no one who is using the cluster mode in a serious production environment.

My response might sound a bit harsh, but anyhow the only serious way to benchmark something is (1) using your current use case and not a toy example and (2) doing it yourself to be sure it's not flawed.

wilzbach avatar Sep 29 '17 04:09 wilzbach

@wilzbach I am pretty impressed by your down to earth communication skills.

NodeJS 5.x is almost 2 years old and NodeJS releases over the last couple of years underwent serious changes. you may see it here https://github.com/nodejs/node/blob/master/CHANGELOG.md

Cluster module is necessary to achieve multi core support, I am using it through PM2 from last 3 years and never had a problem and never served less than 1K requests (which hits db or other third party services) per CPU core.

I was trying to help to make Benchmark more reasonable from real world perspective.

corporatepiyush avatar Sep 29 '17 05:09 corporatepiyush

@corporatepiyush Thank's for your feedback. Indeed node version is outdated, the latest tls is 6.11.3. Feel free to submit a PR with improvements.

llaine avatar Sep 30 '17 11:09 llaine