protocol icon indicating copy to clipboard operation
protocol copied to clipboard

test: Get to 100% test coverage

Open victorges opened this issue 1 year ago • 2 comments

What does this pull request do? Explain your changes. (required) This is just to get back to 100% coverage on BondingManager and Manager code by checking an unexercised code path.

Specific updates (required)

  • Add test for invalid treasury cut rate
  • Add test for Manager.whenSystemNotPaused

How did you test each of these updates (required) yarn test

Does this pull request close any open issues? No.

Checklist:

  • [ ] README and other documentation updated
  • [x] All tests using yarn test pass

victorges avatar Mar 15 '24 19:03 victorges

🥳 Screenshot 2024-03-15 at 17 04 22

victorges avatar Mar 15 '24 20:03 victorges

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00000%. Comparing base (3966c9d) to head (bde5baa).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##               delta         #639         +/-   ##
====================================================
+ Coverage   99.61861%   100.00000%   +0.38139%     
====================================================
  Files             29           29                 
  Lines           1311         1311                 
  Branches         218          218                 
====================================================
+ Hits            1306         1311          +5     
+ Misses             5            0          -5     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3966c9d...bde5baa. Read the comment docs.

see 1 file with indirect coverage changes

codecov[bot] avatar Mar 15 '24 20:03 codecov[bot]