livekit
would be great to add fullScreen button in controlsView
Though I can get "full screen" control on individual video frame, it would be great in my integration if I can have full screen button for the whole LiveKitRoom component!
I have no expirience with full views, but with some directions, I probably can create a PR. What do you think ?
@Niss333 This is a great writeup how custom controls can be implemented: https://css-tricks.com/custom-controls-in-html5-video-full-screen/
Would be absolutely a worthwhile addition imho, and we would find out if it is possible to workaround #81 this way.
@Philzen many thanks, that is a great answer. Maybe I'm wrong, but main workaround should be to cancel that transform in VideoRenderer.tsx. This screwing up too much, from screen sharing to custom controls. Instead, there should be feature request to WebKit team to add a 'local' flag for video stream
there should be feature request to WebKit team to add a 'local' flag for video stream
That'd be not only the WebKit team, but also the Firefox team i guess – so effectively this suggests to introduce a new attribute on the <video>-element into the HTML W3C standard (where i wouldn't tie local to mirroring, but maybe call it mirrored, to make clearer what it does). That is a loooong road to go down there.
main workaround should be to cancel that transform in VideoRenderer.tsx
#81 was merged yesterday which make that possible.