client-sdk-unity icon indicating copy to clipboard operation
client-sdk-unity copied to clipboard

Inconsistent Firing of Disconnect Events Across Disconnection Paths

Open holofermes opened this issue 9 months ago • 0 comments

Currently, the Disconnected event does not consistently fire across all disconnection paths. Specifically, when disconnection occurs through the DisconnectReceived callback, the event is not triggered at all. Moreover the disconnect event should be fired with a DisconnectReason, currently it passes the room instead.

Proposed Solution:

  • Introduce a DisconnectDelegate that includes a DisconnectReason.
  • Update the Disconnected event to use this new delegate.
  • Ensure that the Disconnected event fires with a reason when disconnection occurs via the DisconnectReceived callback.

Looking at the enum for DisconnectReason I am not sure which one is the best in this case. I will make a PR using ClientInitiated, but this is arbitrary and can/should be revised as needed.

holofermes avatar Apr 11 '25 03:04 holofermes