client-sdk-js icon indicating copy to clipboard operation
client-sdk-js copied to clipboard

feat: add resuming state to room events

Open holzgeist opened this issue 2 years ago • 3 comments

I want to give users feedback about network events ASAP. Currently, if network access is temporarily lost, the first event that gets emitted is a Reconnected event. Having access to the internal Resuming event, we can show the users that something is up. This should help to avoid repeated "Hello? Can you hear me?" that nobody will ever hear ;)

WDYT?

holzgeist avatar Feb 05 '24 14:02 holzgeist

⚠️ No Changeset found

Latest commit: fea20034f6fc83958b628d86adda9ff2e21c3ce9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 05 '24 14:02 changeset-bot[bot]

I didn't add a changeset because I'm not sure about the severity of this change. Is adding an enum variant a major/breaking change?

holzgeist avatar Feb 05 '24 14:02 holzgeist

hi @holzgeist,

thanks for the PR! We're still discussing internally when and how to exactly emit such an event. We'll come back to this once a decision has been made.

lukasIO avatar Mar 04 '24 11:03 lukasIO

closing, because same functionality has been implemented in #1158

holzgeist avatar Jun 27 '24 12:06 holzgeist

thank you for your efforts here, @holzgeist !

lukasIO avatar Jul 01 '24 07:07 lukasIO