agents icon indicating copy to clipboard operation
agents copied to clipboard

add FAL's whizper support

Open jayeshp19 opened this issue 1 year ago • 1 comments

implements https://github.com/livekit/agents/issues/980

image

PTAL @davidzhao @theomonnom

jayeshp19 avatar Oct 28 '24 03:10 jayeshp19

🦋 Changeset detected

Latest commit: 43862539feefb82b78a33bdd1473632eed27f35e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-plugins-fal Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 28 '24 03:10 changeset-bot[bot]

Types seems wrong, can you add this plugin to the type checks CI https://github.com/livekit/agents/blob/0c9eac91938d21ba4c2f2d16cfe05fb8fa237786/.github/workflows/tests.yml#L102

theomonnom avatar Nov 14 '24 20:11 theomonnom

sry can you also add it here :) https://github.com/livekit/agents/blob/main/.github/workflows/ci.yml

theomonnom avatar Nov 14 '24 21:11 theomonnom

@theomonnom it seems we need to add directory first image

jayeshp19 avatar Nov 14 '24 21:11 jayeshp19

mmh not sure maybe you need a py.typed file (e.g)

theomonnom avatar Nov 14 '24 21:11 theomonnom

I've added py.typed and changed initial version to 0.1.0 from 0.0.0, still facing the same issue @theomonnom

jayeshp19 avatar Nov 14 '24 22:11 jayeshp19

Pretty sure the types aren't good, but the CI isn't working for whatever reasons. Can you run mypy locally on your machine to do type checks?

theomonnom avatar Nov 15 '24 09:11 theomonnom

@jayeshp19 py.typed is added to the wrong dir, it seems to be sitting at root: livekit-plugins/livekit-plugins-fal/py.typed

davidzhao avatar Nov 15 '24 18:11 davidzhao