agents icon indicating copy to clipboard operation
agents copied to clipboard

Add Google Generative AI LLMs

Open rsinnet opened this issue 1 year ago • 5 comments

Add Google Gemini LLMs via Google API with function calling support.

Fixes: #456

rsinnet avatar Sep 18 '24 18:09 rsinnet

🦋 Changeset detected

Latest commit: 7944612b6128ef17fd5d6c8dafdfe290a6c020ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-plugins-google Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 18 '24 18:09 changeset-bot[bot]

Just so you're aware, there's two Gemini API's. The second one is Google's Vertex API, and I believe it's slightly better suited here.

AphinityApp avatar Sep 18 '24 21:09 AphinityApp

Just so you're aware, there's two Gemini API's. The second one is Google's Vertex API, and I believe it's slightly better suited here.

Do you think it makes sense to support both, e.g., through the constructor or class methods? Or just Vertex?

rsinnet avatar Sep 19 '24 16:09 rsinnet

_

thuto888 avatar Oct 07 '24 20:10 thuto888

Commenting on this for support.

Base on the documentation, I think vertex ai is more production and enterprise ready. I have a vertex version working locally. I can add @rsinnet as a co-author in a new PR if this is something you want.

ChenghaoMou avatar Oct 15 '24 13:10 ChenghaoMou

Pleasure to get this email

On Tue, 15 Oct 2024, 15:38 Chenghao Mou, @.***> wrote:

Commenting on this for support.

Base on the documentation https://cloud.google.com/vertex-ai/generative-ai/docs/migrate/migrate-google-ai, I think vertex ai is more production and enterprise ready. I have a vertex version working locally. I can add @rsinnet https://github.com/rsinnet as a co-author in a new PR if this is something you want.

— Reply to this email directly, view it on GitHub https://github.com/livekit/agents/pull/777#issuecomment-2413945597, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJ4ZBAV73SER3CX3AYFZF7LZ3ULETAVCNFSM6AAAAABOOJLKDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJTHE2DKNJZG4 . You are receiving this because you commented.Message ID: @.***>

thuto888 avatar Dec 28 '24 13:12 thuto888

thank you for the PR, closing this as support has already been added

davidzhao avatar Apr 06 '25 06:04 davidzhao