agents icon indicating copy to clipboard operation
agents copied to clipboard

blingfire: add version constraints for pybind

Open jjmaldonis opened this issue 2 months ago • 2 comments

pybind recently updated to v3.0.0 which includes breaking changes that are incompatible with the existing implementation of blingfire. This PR fixes pybind11 to >=2.13.6,<3.0 which ensures v2 is used.

jjmaldonis avatar Nov 12 '25 22:11 jjmaldonis

Should we just recompile blingfire using the new ABIs?

theomonnom avatar Nov 12 '25 23:11 theomonnom

I don't know how your processes work so I don't have a strong opinion.

I wanted to contribute to this repo, and in order to run the examples from a local install I had to compile blingfire from scratch to get the binaries to link correctly (IIRC).

jjmaldonis avatar Nov 13 '25 03:11 jjmaldonis