agents icon indicating copy to clipboard operation
agents copied to clipboard

remix_and_resample effect optimization

Open wyz-honey opened this issue 1 year ago • 3 comments


                if isinstance(data, rtc.AudioFrame):
                    # TODO(theomonnom): The remix_and_resample method is low quality
                    # and should be replaced with a continuous resampling
                    frame = data.remix_and_resample(
                        self._sample_rate, self._num_channels
                    )

When will this TODO be optimized? After testing, the accuracy of this solution is much different from that of using pyaudio to read data from the microphone.

wyz-honey avatar May 17 '24 15:05 wyz-honey

yeah we are working on it

davidzhao avatar May 19 '24 05:05 davidzhao

Great job, looking forward to it, thank you

wyz-honey avatar May 22 '24 16:05 wyz-honey

+1

ChrisFeldmeier avatar Sep 08 '24 20:09 ChrisFeldmeier

Hey, sorry for the late reply. We released a high-quality resampler in rtc-v0.17.1 about a month ago (using SoX)

https://github.com/livekit/python-sdks/releases/tag/rtc-v0.17.1

theomonnom avatar Oct 15 '24 23:10 theomonnom