hovercraft icon indicating copy to clipboard operation
hovercraft copied to clipboard

bbPress toolbar buttons disappeared

Open siliconforks opened this issue 1 year ago • 3 comments

For an example, look at the form on https://slickstack.io/forum

bbpress

It looks like they disappeared with commit e2407ee9405f79899270765a5dc40117fb9add3d about a month ago.

siliconforks avatar Sep 13 '24 15:09 siliconforks

Thank you @siliconforks

Hmm maybe it needs a fixed height or something? A lot of bbPress stuff is hardcoded and not easy to play with...

jessuppi avatar Sep 15 '24 09:09 jessuppi

The bbPress default CSS is complicated, but it has a min-height value specified which seems to be necessary for the button to display correctly. Unfortunately e2407ee9405f79899270765a5dc40117fb9add3d added min-height: auto !important; which overrides this...

siliconforks avatar Sep 15 '24 11:09 siliconforks

Looks like we can fix it with more specific CSS for .quicktags-toolbar input

Ref: https://github.com/littlebizzy/hovercraft/commit/84e84d1a8d9392d136684e640a2fd6ecf92cb8bb Ref: https://github.com/littlebizzy/hovercraft/commit/998dc769e594f70b9226dd2118a77be03e48e969

Not a fan of unnecessary !important but safer for now...

jessuppi avatar Sep 18 '24 09:09 jessuppi