Add exception to details dict in on_backoff() and on_giveup() handlers

Open petamas opened this issue 3 years ago • 6 comments

Closes #145.

Possibly also closes #72, but I'm not 100% because it does not address @michaeltcoelho's second point about the empty raise statement.

Jul 19 '22 18:07 petamas

Thanks for this. I want to play with it a little bit before merging, but I don't see any blockers and the implementation looks clean.

Jul 19 '22 18:07 bgreen-litl

@bgreen-litl : not to rush you, but when do you expect to be able to "play with it"?

Jul 31 '22 13:07 petamas

@bgreen-litl : Hi, did you have the time to check out this PR in more detail?

Aug 13 '22 00:08 petamas

I'm on vacation for the next week. I shoukd be able to get to it when I get back. Ping me again in 1.5 weeks if I haven't. Sorry for the delay

Aug 13 '22 18:08 bgreen-litl

It's okay. Thanks for the heads-up!

Aug 13 '22 20:08 petamas

Hi, I completely forgot to remind you after your vacation. Sorry! But now here's a reminder. (Better late than never!)

Sep 05 '22 22:09 petamas

Hi @bgreen-litl, this PR is more than two months old, when do you think you will have time to review it? Thanks in advance!

Oct 04 '22 12:10 petamas

Thank you and sorry it took me so long. This is merged and I am going to do a backoff v2.2.0 release including it

Oct 05 '22 14:10 bgreen-litl