youtube icon indicating copy to clipboard operation
youtube copied to clipboard

Patch to work with current YouTube

Open UFeindschiff opened this issue 5 years ago • 4 comments

Due to some changes on YouTube's end, youtube.Load() would always fail as it didn't find anything matching on the old regular expressions.

These changes make the library work again with YouTube as of 13th of December 2020

UFeindschiff avatar Dec 13 '20 21:12 UFeindschiff

Thank you for the PR and for updating the regex! Really grateful for it as I haven't had time to update this module while working on other projects.

I'll look into getting this thoroughly reviewed, merged, and tested in the coming few days - apologies if this is something you want to be merged ASAP.

lithdew avatar Dec 14 '20 10:12 lithdew

Feel free to take your time. I updated the imports in my personal projects to use my fork for the time being.

The regex for the player config on the embed page sadly also isn't that great which is which is why I then continue to further split the string (which is more of a dirty hack than anything)

UFeindschiff avatar Dec 14 '20 10:12 UFeindschiff

This pull request was made 3 years ago and it was never merged

SantiiRepair avatar Dec 20 '23 11:12 SantiiRepair

Up

QuantF0rce avatar Mar 10 '24 19:03 QuantF0rce