lit icon indicating copy to clipboard operation
lit copied to clipboard

add masonry layout, refactor grid to support masonry

Open graynorton opened this issue 3 years ago • 2 comments

DRAFT

graynorton avatar Sep 01 '22 20:09 graynorton

🦋 Changeset detected

Latest commit: 5bbd231a0967f0ed11b584aa8913d21aae505819

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/virtualizer Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 01 '22 20:09 changeset-bot[bot]

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -5% - +3% (-1.14ms - +0.58ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 83.87ms - 90.05ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +4% (-1.10ms - +1.38ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -9% - +2% (-1.04ms - +0.22ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +3% (-0.93ms - +1.74ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +3% (-1.28ms - +1.79ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 701.98ms - 711.04ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +3% (-3.75ms - +2.25ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +4% (-2.12ms - +10.32ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +1% (-1.27ms - +1.54ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +0% (-6.16ms - +1.57ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 705.69ms - 713.44ms
  • reactive-element-list: unsure 🔍 -0% - +1% (-2.46ms - +5.33ms)
    this-change vs tip-of-tree

Results

lit-element-list
  • Browser: chrome-headless 108.0.5359.94
  • Sample size: 50
  • Built by: Benchmarks #4166
  • Commit: 38b684c

render

VersionAvg timevs
83.87ms - 90.05ms-

update

VersionAvg timevs
701.98ms - 711.04ms-

update-reflect

VersionAvg timevs
705.69ms - 713.44ms-
lit-html-kitchen-sink
  • Browser: chrome-headless 108.0.5359.94
  • Sample size: 30
  • Built by: Benchmarks #4166
  • Commit: 38b684c

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
30.44ms - 31.96ms-unsure 🔍
-4% - +4%
-1.10ms - +1.38ms
unsure 🔍
-0% - +6%
-0.12ms - +1.90ms
tip-of-tree
tip-of-tree
30.08ms - 32.04msunsure 🔍
-4% - +4%
-1.38ms - +1.10ms
-unsure 🔍
-1% - +6%
-0.43ms - +1.93ms
previous-release
previous-release
29.64ms - 30.97msunsure 🔍
-6% - +0%
-1.90ms - +0.12ms
unsure 🔍
-6% - +1%
-1.93ms - +0.43ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
80.49ms - 84.22ms-unsure 🔍
-4% - +3%
-3.75ms - +2.25ms
faster ✔
0% - 7%
0.31ms - 5.75ms
tip-of-tree
tip-of-tree
80.76ms - 85.46msunsure 🔍
-3% - +5%
-2.25ms - +3.75ms
-unsure 🔍
-6% - +1%
-5.35ms - +0.80ms
previous-release
previous-release
83.40ms - 87.37msslower ❌
0% - 7%
0.31ms - 5.75ms
unsure 🔍
-1% - +7%
-0.80ms - +5.35ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
21.74ms - 22.81ms-unsure 🔍
-5% - +3%
-1.14ms - +0.58ms
unsure 🔍
-6% - +2%
-1.32ms - +0.52ms
tip-of-tree
tip-of-tree
21.88ms - 23.23msunsure 🔍
-3% - +5%
-0.58ms - +1.14ms
-unsure 🔍
-5% - +4%
-1.12ms - +0.89ms
previous-release
previous-release
21.92ms - 23.42msunsure 🔍
-2% - +6%
-0.52ms - +1.32ms
unsure 🔍
-4% - +5%
-0.89ms - +1.12ms
-
lit-html-repeat
  • Browser: chrome-headless 108.0.5359.94
  • Sample size: 30
  • Built by: Benchmarks #4166
  • Commit: 38b684c

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
11.12ms - 12.01ms-unsure 🔍
-9% - +2%
-1.04ms - +0.22ms
unsure 🔍
-7% - +3%
-0.79ms - +0.36ms
tip-of-tree
tip-of-tree
11.52ms - 12.42msunsure 🔍
-2% - +9%
-0.22ms - +1.04ms
-unsure 🔍
-3% - +7%
-0.38ms - +0.76ms
previous-release
previous-release
11.42ms - 12.14msunsure 🔍
-3% - +7%
-0.36ms - +0.79ms
unsure 🔍
-6% - +3%
-0.76ms - +0.38ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
267.64ms - 277.68ms-unsure 🔍
-1% - +4%
-2.12ms - +10.32ms
unsure 🔍
-2% - +3%
-4.66ms - +9.38ms
tip-of-tree
tip-of-tree
264.88ms - 272.24msunsure 🔍
-4% - +1%
-10.32ms - +2.12ms
-unsure 🔍
-3% - +2%
-7.87ms - +4.40ms
previous-release
previous-release
265.39ms - 275.20msunsure 🔍
-3% - +2%
-9.38ms - +4.66ms
unsure 🔍
-2% - +3%
-4.40ms - +7.87ms
-
lit-html-template-heavy
  • Browser: chrome-headless 108.0.5359.94
  • Sample size: 50
  • Built by: Benchmarks #4166
  • Commit: 38b684c

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
52.48ms - 54.85ms-unsure 🔍
-2% - +3%
-0.93ms - +1.74ms
unsure 🔍
-3% - +2%
-1.44ms - +1.34ms
tip-of-tree
tip-of-tree
52.64ms - 53.88msunsure 🔍
-3% - +2%
-1.74ms - +0.93ms
-unsure 🔍
-3% - +1%
-1.41ms - +0.50ms
previous-release
previous-release
52.99ms - 54.43msunsure 🔍
-2% - +3%
-1.34ms - +1.44ms
unsure 🔍
-1% - +3%
-0.50ms - +1.41ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
108.58ms - 110.53ms-unsure 🔍
-1% - +1%
-1.27ms - +1.54ms
unsure 🔍
-2% - +1%
-1.73ms - +1.21ms
tip-of-tree
tip-of-tree
108.41ms - 110.43msunsure 🔍
-1% - +1%
-1.54ms - +1.27ms
-unsure 🔍
-2% - +1%
-1.88ms - +1.10ms
previous-release
previous-release
108.71ms - 110.91msunsure 🔍
-1% - +2%
-1.21ms - +1.73ms
unsure 🔍
-1% - +2%
-1.10ms - +1.88ms
-
reactive-element-list
  • Browser: chrome-headless 108.0.5359.94
  • Sample size: 50
  • Built by: Benchmarks #4166
  • Commit: 38b684c

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
53.53ms - 55.93ms-unsure 🔍
-2% - +3%
-1.28ms - +1.79ms
unsure 🔍
-3% - +3%
-1.49ms - +1.57ms
tip-of-tree
tip-of-tree
53.52ms - 55.43msunsure 🔍
-3% - +2%
-1.79ms - +1.28ms
-unsure 🔍
-3% - +2%
-1.57ms - +1.13ms
previous-release
previous-release
53.74ms - 55.64msunsure 🔍
-3% - +3%
-1.57ms - +1.49ms
unsure 🔍
-2% - +3%
-1.13ms - +1.57ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
704.47ms - 710.03ms-unsure 🔍
-1% - +0%
-6.16ms - +1.57ms
unsure 🔍
-0% - +1%
-2.95ms - +5.41ms
tip-of-tree
tip-of-tree
706.86ms - 712.23msunsure 🔍
-0% - +1%
-1.57ms - +6.16ms
-unsure 🔍
-0% - +1%
-0.60ms - +7.64ms
previous-release
previous-release
702.90ms - 709.15msunsure 🔍
-1% - +0%
-5.41ms - +2.95ms
unsure 🔍
-1% - +0%
-7.64ms - +0.60ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
739.56ms - 744.83ms-unsure 🔍
-0% - +1%
-2.46ms - +5.33ms
unsure 🔍
-0% - +1%
-3.52ms - +4.83ms
tip-of-tree
tip-of-tree
737.89ms - 743.62msunsure 🔍
-1% - +0%
-5.33ms - +2.46ms
-unsure 🔍
-1% - +0%
-5.11ms - +3.54ms
previous-release
previous-release
738.30ms - 744.78msunsure 🔍
-1% - +0%
-4.83ms - +3.52ms
unsure 🔍
-0% - +1%
-3.54ms - +5.11ms
-

tachometer-reporter-action v2 for Benchmarks

github-actions[bot] avatar Sep 01 '22 20:09 github-actions[bot]