waves-core icon indicating copy to clipboard operation
waves-core copied to clipboard

output file: extension

Open vincent-lefort opened this issue 7 years ago • 5 comments

When configuring a service with an output file, the 'extension' field behaviour is weird. If defined with 'name' and 'extension' fields, a remote output file is correctly retreived by WAVES, but is nammed on the local file system without the extension. Thus, we recommend not to use the 'extension' field.

vincent-lefort avatar Oct 31 '18 14:10 vincent-lefort

I'll have a look, this is probabely related to this part of the code: https://github.com/lirmm/waves-core/blob/d79e779696215ec90c02e9d310c8d9b979c830c6/waves/wcore/models/jobs.py#L955

https://github.com/lirmm/waves-core/blob/d79e779696215ec90c02e9d310c8d9b979c830c6/waves/wcore/models/jobs.py#L997

more specifically there https://github.com/lirmm/waves-core/blob/d79e779696215ec90c02e9d310c8d9b979c830c6/waves/wcore/models/jobs.py#L1058

Expected output are created here: https://github.com/lirmm/waves-core/blob/d79e779696215ec90c02e9d310c8d9b979c830c6/waves/wcore/models/jobs.py#L538

https://github.com/lirmm/waves-core/blob/d79e779696215ec90c02e9d310c8d9b979c830c6/waves/wcore/api/v2/serializers/services.py#L36

marcoooo avatar Nov 21 '18 21:11 marcoooo

in the same way, if output "File name" is inserted without extension : "output" instead of "output.txt". The jobs details page (/waves/jobs/xxxxx) always give an output file 'Not available for now' because WAVES search for a file "output." instead of just "output"

Sylmila avatar Dec 05 '18 15:12 Sylmila

I finally figured it out. Extension is not used to compute expected output file full name. Only output value is used. In fact this was made on purpose because extension is only supposed to help adding correct headers when downloading submission output.

marcoooo avatar Feb 19 '19 23:02 marcoooo

in the same way, if output "File name" is inserted without extension : "output" instead of "output.txt". The jobs details page (/waves/jobs/xxxxx) always give an output file 'Not available for now' because WAVES search for a file "output." instead of just "output"

Should be fixed: https://github.com/lirmm/waves-core/tree/bugfix/files_inputs. Before submitting PR, I'll correct other tickets: #11 and #1

marcoooo avatar Feb 19 '19 23:02 marcoooo

@vincent-lefort can you confirm this has been fixed in v1.6.7?

marcoooo avatar Jan 08 '20 22:01 marcoooo