libwacom icon indicating copy to clipboard operation
libwacom copied to clipboard

Generate the device Class programmatically

Open whot opened this issue 1 year ago • 2 comments

Nothing uses libwacom_get_class() (except for identifying remotes, see #779) but we still have to add it each .tablet file. Since we don't have any known callers we can just generate the value:

  • IntegratedIn=Display -> Cintiq
  • IntegratedIn=Display;System -> ISDV4
  • IntegratedIn= -> Bamboo

whot avatar Oct 16 '24 04:10 whot

I started work on this, but it dawned on me that there's a lot of classes other than Cintiq, ISDV4 and Bamboo. I guess it makes sense to only generate it programmatically if it doesn't have an explicit one defined?

redstrate avatar Oct 16 '24 21:10 redstrate

The only class that currently matters is the WCLASS_REMOTE, all the others are never used for anything (afaik). Many are expired and now pointless anyway (Intuos*, Bamboo, Graphire). So the only ones that "matter" are Cintiq, Intuos5 and ISDV4 - all of which we can auto-assign.

And the remote of course :)

whot avatar Oct 21 '24 03:10 whot

Fixed in #814

whot avatar Nov 01 '24 01:11 whot