Improvements: Run web only if enabled + Rename svc-beets + Add s6 overlay for drop2beets
- [x] I have read the contributing guideline and understand that I have made the correct modifications
Description:
- Run web only if enabled: This fixes #141
- Rename svc-beets: In order to reflect what this s6 overlay does it's better to name it beets-web since the only purpose of this overlay is to run the web plugin as a longterm service
- Add s6 overlay for drop2beets: This is not enabled by default but the required s6 overlay to be able to enable it was added here
Benefits of this PR and context:
It fixes #141 and all users would benefit from the other commits
How Has This Been Tested?
I've used the following docker-compose.yml to run and test my changes:
services:
beets:
build: .
container_name: beets
environment:
- PUID=1000
- PGID=1000
- TZ=Europe/Berlin
- DOCKER_MODS=linuxserver/mods:universal-package-install
- INSTALL_PIP_PACKAGES=drop2beets
volumes:
- ./config:/config
- ./dropbox:/dropbox
- ./logs:/logs
- ./music:/music
restart: unless-stopped
- I've checked w/o plugin
webif the error messageerror: unknown command 'web'dissappeared. - I've checked w/ plugin
webif the web service is up and running - I've checked w/ plugin
drop2beetsif the service is up and running
Source / References:
https://github.com/linuxserver/docker-beets/issues/141 https://github.com/linuxserver/docker-beets/pull/138
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-1185004a-dev-f1f827b03fd0ed097b96b88a3e05c22f0bb5a59c-pr-142/index.html https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-1185004a-dev-f1f827b03fd0ed097b96b88a3e05c22f0bb5a59c-pr-142/shellcheck-result.xml
| Tag | Passed |
|---|---|
| amd64-2.5.1-pkg-1185004a-dev-f1f827b03fd0ed097b96b88a3e05c22f0bb5a59c-pr-142 | ✅ |
| arm64v8-2.5.1-pkg-1185004a-dev-f1f827b03fd0ed097b96b88a3e05c22f0bb5a59c-pr-142 | ✅ |
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-1185004a-dev-ebffeef570b82696f320b9b7fb1ae10e973a76fd-pr-142/index.html https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-1185004a-dev-ebffeef570b82696f320b9b7fb1ae10e973a76fd-pr-142/shellcheck-result.xml
| Tag | Passed |
|---|---|
| amd64-2.5.1-pkg-1185004a-dev-ebffeef570b82696f320b9b7fb1ae10e973a76fd-pr-142 | ✅ |
| arm64v8-2.5.1-pkg-1185004a-dev-ebffeef570b82696f320b9b7fb1ae10e973a76fd-pr-142 | ✅ |
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-1185004a-dev-f5cfc0cb136d2bbd3c9c02dc7cb4d0c93161d339-pr-142/index.html https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-1185004a-dev-f5cfc0cb136d2bbd3c9c02dc7cb4d0c93161d339-pr-142/shellcheck-result.xml
| Tag | Passed |
|---|---|
| amd64-2.5.1-pkg-1185004a-dev-f5cfc0cb136d2bbd3c9c02dc7cb4d0c93161d339-pr-142 | ✅ |
| arm64v8-2.5.1-pkg-1185004a-dev-f5cfc0cb136d2bbd3c9c02dc7cb4d0c93161d339-pr-142 | ✅ |
I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-87cc8640-dev-b1dca77ba4a65a1c0a56c4b73f7cf0560267ae24-pr-142/index.html https://ci-tests.linuxserver.io/lspipepr/beets/2.5.1-pkg-87cc8640-dev-b1dca77ba4a65a1c0a56c4b73f7cf0560267ae24-pr-142/shellcheck-result.xml
| Tag | Passed |
|---|---|
| amd64-2.5.1-pkg-87cc8640-dev-b1dca77ba4a65a1c0a56c4b73f7cf0560267ae24-pr-142 | ✅ |
| arm64v8-2.5.1-pkg-87cc8640-dev-b1dca77ba4a65a1c0a56c4b73f7cf0560267ae24-pr-142 | ✅ |
